Configurable container images for cert-csi #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhatdell
requested review from
adarsh-dell,
AkshaySainiDell,
bharathsreekanth,
harishp8889,
JacobGros,
Prabhu-Dell,
rajkumar-palani,
khareRajshree,
shefali-malhotra,
panigs7,
tssushma,
gilltaran and
shanmydell
as code owners
atye
reviewed
Dec 1, 2023
|
Will there be a csm-docs update describing how to use this? |
adarsh-dell
reviewed
Dec 4, 2023
| @@ -835,6 +842,12 @@ func (cts *CapacityTrackingSuite) Run(ctx context.Context, storageClass string, | |||
| if sc.HasError() { | |||
| return delFunc, sc.GetError() | |||
| } | |||
|
|
|||
| if cts.Image == "" { | |||
| log.Info("Using default image") | |||
There was a problem hiding this comment.
Can we enhance this log by stating that 'docker.io/centos:latest' is the default image?
adarsh-dell
reviewed
Dec 4, 2023
pkg/cmd/testcmd.go
Outdated
| @@ -841,10 +1004,22 @@ func getBlockSnapCommand(globalFlags []cli.Flag) cli.Command { | |||
| snapClass := c.String("volumeSnapshotClass") | |||
| size := c.String("size") | |||
| accessMode := c.String("access-mode") | |||
| imageConfigPath := c.String("image-config") | |||
| var testImage string | |||
There was a problem hiding this comment.
@rishabhatdell , what are your thoughts on incorporating a generic/common function to eliminate code duplication? It seems we've duplicated the same logic across multiple sections, checking for the same conditions in each suite.
5 tasks
here is the PR: dell/csm-docs#928 |
suryagupta4
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows cert-csi to use custom images for creating containers by passing an image config YAML file as an argument. The YAML file should have linux(test) and postgres images name with their corresponding image URL. For example:
To use this feature, run cert-csi with the option --image-config /path/to/config.yaml along with any other arguments.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Built binary and executed unit tests
Executed the cert-csi to verify whether the provided image was utilized in the container build process
