Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata sidecar version bump #159

Merged
merged 2 commits into from
Jun 5, 2023
Merged

metadata sidecar version bump #159

merged 2 commits into from
Jun 5, 2023

Conversation

nitesh3108
Copy link
Contributor

Description

metadata sidecar version bump

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#843

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

rajkumar-palani
rajkumar-palani previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chimanjain
chimanjain previously approved these changes Jun 5, 2023
View reviewed changes
rensyct
rensyct reviewed Jun 5, 2023
View reviewed changes
driverconfig/config.yaml Outdated
- version: v122
tag: dellemc/csi-metadata-retriever:v1.3.0
tag: dellemc/csi-metadata-retriever:v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change required for K8s 1.22 and 1.23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 1.22 and 1.23

@nitesh3108 nitesh3108 dismissed stale reviews from chimanjain and rajkumar-palani via 3bb3479 June 5, 2023 07:41
@nitesh3108 nitesh3108 merged commit 4e92419 into main Jun 5, 2023
@nitesh3108 nitesh3108 deleted the gomodule-update branch June 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimanjain chimanjain chimanjain approved these changes

@rensyct rensyct rensyct approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitesh3108 @chimanjain @rajkumar-palani @rensyct