266 idrac_network.py fails with AttributeError: 'NoneType' object has no attribute 'iDRAC'

[grantcurell]

README.md:

• Added TOC
• Based on user feedback took @anupamaloke 's answer and provided an explanation for the required shares along with how to easily handle the share
• Changed the header Playbooks to Sample Playbooks so user's would have a better idea of what was there

dellemc_configure_idrac_eventing.py
dellemc_configure_idrac_services.py
dellemc_idrac_lc_attributes.py
dellemc_system_lockdown_mode.py
idrac_bios.py
idrac_firmware.py
idrac_network.py
idrac_syslog.pyidrac_timezone_ntp.py:

• Added error handling such that if a share is used and not valid the module gracefully fails.
• Fixes idrac_network.py fails with AttributeError: 'NoneType' object has no attribute 'iDRAC' #266
• Fixes module dellemc.openmanage.idrac_network use share_name as mandatory #194
• Fixes idrac_bios : 'NoneType' object has no attribute 'BIOS' #160

All files:

• optimized imports

Signed-off-by: Grant Curell grant_curell@dell.com

[jagadeeshnv]

@grantcurell
Apologies for the delay. The content looks fine, but need these changes.
Please change the title to something like "Handling invalid share and unused imports cleanup" or whichever is more appropriate considering all the modules modified in this PR.
As a first set of comments.

1. The README.md changes can be a separated from this PR for now.
2. Please update the content to the latest
3. We will review the message and get back on it
4. Please exclude ome and redfish modules from this PR and lets keep it to idrac only

[jagadeeshnv]

@grantcurell Please update the file tests/unit/plugins/modules/test_idrac_firmware.py, then the checks will pass.

[grantcurell]

Apologies - I'll be traveling tomorrow. I'll take a look Monday and make the changes

[grantcurell]

@grantcurell
Apologies for the delay. The content looks fine, but need these changes.
Please change the title to something like "Handling invalid share and unused imports cleanup" or whichever is more appropriate considering all the modules modified in this PR.
As a first set of comments.

1. The README.md changes can be a separated from this PR for now.
2. Please update the content to the latest
3. We will review the message and get back on it
4. Please exclude ome and redfish modules from this PR and lets keep it to idrac only

I just want to make sure I understand correctly, the request is to delete the changes to all the files in the commit except idrac_network.py and remove the fixes for #194 and #160 and leave both of those tickets open?

[jagadeeshnv]

@grantcurell

• Please retain the changes to all iDRAC modules - idrac_*
• Delete the README and ome_* modules from this PR.(Preferably move to a new PR)
• Change the message as below for the iDRAC modules

module.fail_json(msg="Unable to access the share. Ensure that the share name, "
                             "share mount, and share credentials provided are correct.")

[jagadeeshnv]

@grantcurell Can you enable "Allow edits from maintainers.” so that we can update tests/unit/plugins/modules/test_idrac_firmware.py for the checks to pass and the merge this PR

[jagadeeshnv]

@grantcurell
plugins/modules/idrac_firmware.py had issues with indentation and duplicate if conditions and UT checks for this was failing as UT file was not committed. We tried to exclude idrac_firmware.py from the commit, Since our release activity is in progress today(6/24)

Can you please fix the issues or restore the idrac_firmware module without any changes so that checks will pass.
For your quick reference, PR #288 has the required changes.

[grantcurell]

Apologies for not being more responsive. I took on a new project and am working pretty well at max capacity. I'll be out of town tomorrow but I'll take a look when I'm at the airport Monday

[rajeevarakkal]

Apologies for not being more responsive. I took on a new project and am working pretty well at max capacity. I'll be out of town tomorrow but I'll take a look when I'm at the airport Monday

No problem, since our release is due, we will merge now and we will push the necessary UT correction immediately