Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the linting error #45

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Fixing the linting error #45

merged 3 commits into from
Dec 15, 2023

Conversation

tssushma
Copy link
Contributor

@tssushma tssushma commented Sep 29, 2023 •
edited by shanmydell
Loading

Description

Fixing the linting error

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@tssushma
Update linters.yaml
6bf026f 
Updated the go version
@tssushma
Update linters.yaml
2c562c2 
Updated the go version
@shanmydell shanmydell self-requested a review December 15, 2023 08:00
@shanmydell shanmydell requested a review from nidtara December 15, 2023 08:01
@tssushma tssushma requested a review from boyamurthy December 15, 2023 08:31
@shanmydell shanmydell merged commit 2527f55 into main Dec 15, 2023
1 check passed
@shanmydell shanmydell deleted the gobrick_lint branch December 15, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@santhoshhs10 santhoshhs10 santhoshhs10 approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@nidtara nidtara Awaiting requested review from nidtara

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tssushma @shanmydell @santhoshhs10