Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github Workflow and Fixed Golangci-lint errors. #23

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Update Github Workflow and Fixed Golangci-lint errors. #23

merged 5 commits into from
Apr 30, 2024

Conversation

chimanjain
Copy link

@chimanjain chimanjain commented Apr 29, 2024 •
edited
Loading

Description

  • Update github Actions
  • Golangci lint
  • Fix Golangci-lint errors

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

@chimanjain chimanjain changed the title Update Github Workflow Update Github Workflow and Fixed Golangci-lint errors. Apr 29, 2024
HarishH-DELL
HarishH-DELL approved these changes Apr 30, 2024
View reviewed changes
Copy link

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shefali-malhotra
shefali-malhotra approved these changes Apr 30, 2024
View reviewed changes
Copy link

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit 8f68925 into main Apr 30, 2024
4 checks passed
@chimanjain chimanjain deleted the upd-workflow branch April 30, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@panigs7 panigs7 Awaiting requested review from panigs7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @shefali-malhotra @HarishH-DELL