Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Unit Tests #6

Merged
merged 29 commits into from
Feb 17, 2022
Merged

Mock Unit Tests #6

merged 29 commits into from
Feb 17, 2022

Conversation

harshitap26
Copy link
Collaborator

@harshitap26 harshitap26 commented Feb 13, 2022 •
edited
Loading

Description

Unit and Mock tests for gonvme.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#158

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on linux environment with nvme library installed
  • Unit tests included are executing successfully
  • Tested the changes made in the nvme connect function. Able to separate different conditions in case of same exit status.

@harshitap26 harshitap26 requested a review from prablr79 February 13, 2022 17:53
francis-nijay
francis-nijay previously approved these changes Feb 13, 2022
View reviewed changes
gonvme_mock.go Outdated Show resolved Hide resolved
@harshitap26 harshitap26 requested a review from kumarp20 February 14, 2022 06:57
harishp8889
harishp8889 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new lines at the end of files wherever it is reported

harishp8889
harishp8889 previously approved these changes Feb 14, 2022
View reviewed changes
@harshitap26
Copy link
Collaborator Author

Add new lines at the end of files wherever it is reported

@harishp8889 added new lines wherever reported. Thanks

francis-nijay
francis-nijay requested changes Feb 14, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
gonvme_mock.go Show resolved Hide resolved
gonvme_mock.go Show resolved Hide resolved
testdata/with_comments.nvme Outdated Show resolved Hide resolved
@harshitap26
Unit and Mock tests
3428e1f
@harshitap26
Merging NVMe list changes
897ef11 
Merge branch 'main' of github.com:dell/gonvme into Mock-Unit-Tests
@francis-nijay francis-nijay merged commit 306d51e into main Feb 17, 2022
@mjsdell mjsdell deleted the Mock-Unit-Tests branch October 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 approved these changes

@prablr79 prablr79 prablr79 approved these changes

@francis-nijay francis-nijay francis-nijay approved these changes

@spriya-m spriya-m spriya-m approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran

@kumarp20 kumarp20 Awaiting requested review from kumarp20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshitap26 @harishp8889 @prablr79 @francis-nijay @spriya-m