Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ArrayMigration src to Makefile #42

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Adds ArrayMigration src to Makefile #42

merged 1 commit into from
Mar 6, 2023

Conversation

delldubey
Copy link
Collaborator

@delldubey delldubey commented Mar 6, 2023 •
edited
Loading

Description

  • Update Makefile with ArrayMigration.go

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#701

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test:
    538 scenarios (538 passed)
    3582 steps (3582 passed)
    PASS ok

tssushma
tssushma approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey merged commit db17771 into main Mar 6, 2023
@shanmydell shanmydell deleted the bug-701-makefileUpdate branch March 6, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@tssushma tssushma tssushma approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@nidtara nidtara Awaiting requested review from nidtara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delldubey @shanmydell @tssushma