Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query quota call by path #39

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fix query quota call by path #39

merged 4 commits into from
Apr 12, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Mar 29, 2023 •
edited
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#753

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

  • Fix query quota call by path. Previous code wouldn't have worked if the PowerScale cluster has more than 1000 quotas.
  • Added a workaround fix for SyncIQ job where it could fail with QuotaScan job requirement to be run on target cluster when quota is set on target directories.

Replication tests passed. Please refer to dell/csi-powerscale#182 for test details.

Unit tests are failing. They do fail even on the main branch. I have asked @nitesh3108 to take a look.

donatwork
donatwork approved these changes Apr 11, 2023
View reviewed changes
api/v1/api_v1_quotas.go Show resolved Hide resolved
@santhoshatdell santhoshatdell marked this pull request as ready for review April 11, 2023 17:47
@santhoshatdell santhoshatdell changed the base branch from main to release-1.11.1 April 11, 2023 17:50
@santhoshatdell santhoshatdell merged commit de175a7 into release-1.11.1 Apr 12, 2023
@santhoshatdell santhoshatdell deleted the target-quota-fix branch April 12, 2023 16:54
@santhoshatdell santhoshatdell mentioned this pull request Apr 17, 2023
Merged
4 tasks
nitesh3108 pushed a commit that referenced this pull request Apr 20, 2023
@santhoshatdell
Fix query quota call by path (#39) (#43)
ccfa044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

@gallacher gallacher Awaiting requested review from gallacher

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@meggm meggm Awaiting requested review from meggm

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santhoshatdell @donatwork @ChristianAtDell