Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for PowerScale topology #123

Merged
merged 1 commit into from
Jun 29, 2022
Merged

add support for PowerScale topology #123

merged 1 commit into from
Jun 29, 2022

Conversation

YianZong
Copy link
Contributor

@YianZong YianZong commented Jun 14, 2022 •
edited by gallacher
Loading

Is this a new chart?

No

What this PR does / why we need it:

enable PowerScale topology

Which issue(s) is this PR associated with

Special notes for your reviewer:

This code change has been verified along with changes in karavi-topology PR#116

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

@YianZong YianZong force-pushed the feature-334-PScaleTopo branch 2 times, most recently from 4dfe939 to 8e9fda1 Compare June 14, 2022 04:05
@YianZong YianZong marked this pull request as ready for review June 14, 2022 04:13
forrestxia
forrestxia previously approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@forrestxia forrestxia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@YianZong pls check the end to end logic to ensure this change is respected.

@YianZong YianZong force-pushed the feature-334-PScaleTopo branch from 8e9fda1 to 48ddfe5 Compare June 23, 2022 06:23
taohe1012
taohe1012 previously approved these changes Jun 23, 2022
View reviewed changes
@forrestxia forrestxia requested review from forrestxia and removed request for medegw01 June 24, 2022 08:02
forrestxia
forrestxia previously approved these changes Jun 24, 2022
View reviewed changes
@shaynafinocchiaro
Copy link
Contributor

Can these changes point to the karavi-observability-release branch instead of main. We've recently bumped the versions in Chart.yaml as well. Thank you!

@YianZong YianZong dismissed stale reviews from forrestxia and taohe1012 via 6b6a1b0 June 27, 2022 05:06
@YianZong YianZong force-pushed the feature-334-PScaleTopo branch from 48ddfe5 to 6b6a1b0 Compare June 27, 2022 05:06
@YianZong YianZong changed the base branch from main to karavi-observability-release June 27, 2022 05:06
@YianZong
Copy link
Contributor Author

Can these changes point to the karavi-observability-release branch instead of main. We've recently bumped the versions in Chart.yaml as well. Thank you!

Thanks, @shaynafinocchiaro ! Done.

baoy1
baoy1 previously approved these changes Jun 27, 2022
View reviewed changes
@YianZong YianZong dismissed stale reviews from P-Cao, baoy1, forrestxia, and taohe1012 via f04902c June 28, 2022 14:53
@YianZong YianZong force-pushed the feature-334-PScaleTopo branch from 5814e4c to f04902c Compare June 28, 2022 14:53
sharmilarama
sharmilarama previously approved these changes Jun 28, 2022
View reviewed changes
forrestxia
forrestxia previously approved these changes Jun 28, 2022
View reviewed changes
taohe1012
taohe1012 previously approved these changes Jun 29, 2022
View reviewed changes
baoy1
baoy1 previously approved these changes Jun 29, 2022
View reviewed changes
P-Cao
P-Cao previously approved these changes Jun 29, 2022
View reviewed changes
@YianZong YianZong dismissed stale reviews from P-Cao, baoy1, taohe1012, forrestxia, and sharmilarama via 37e87ae June 29, 2022 05:03
@YianZong YianZong force-pushed the feature-334-PScaleTopo branch from f04902c to 37e87ae Compare June 29, 2022 05:03
@YianZong
Copy link
Contributor Author

I signed the commit and had to push it again. @sharmilarama @shaynafinocchiaro please help review to approve it again, thank you!

@YianZong YianZong merged commit 638be42 into karavi-observability-release Jun 29, 2022
@YianZong YianZong deleted the feature-334-PScaleTopo branch June 29, 2022 12:38
forrestxia added a commit that referenced this pull request Sep 21, 2022
@forrestxia @hoppea2
@shaynafinocchiaro @sharmilarama @YianZong @taohe1012 @atye @EvgenyUglov @baoy1 @bjiang27
charts/karavi-observability Karavi observability release v1.3.0 (#143)
2154435 
* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <yiming.bao@emc.com>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <yiming.bao@dell.com>

Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <66699024+shaynafinocchiaro@users.noreply.github.com>
Co-authored-by: Sharmila Ramamoorthy <sharmila.ramamoorthy@dell.com>
Co-authored-by: YianZong <63342088+YianZong@users.noreply.github.com>
Co-authored-by: taohe1012 <88763781+taohe1012@users.noreply.github.com>
Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>
Co-authored-by: baoy1 <105041111+baoy1@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@emc.com>
Co-authored-by: bjiang27 <105997542+bjiang27@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@dell.com>
forrestxia added a commit that referenced this pull request Sep 21, 2022
@baoy1 @hoppea2
@shaynafinocchiaro @sharmilarama @YianZong @taohe1012 @forrestxia @atye @EvgenyUglov @bjiang27
charts/karavi-observability: Version fix for csm-metrics-powerscale (#…
405a4de 
…148)

* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <yiming.bao@emc.com>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <yiming.bao@dell.com>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <66699024+shaynafinocchiaro@users.noreply.github.com>
Co-authored-by: Sharmila Ramamoorthy <sharmila.ramamoorthy@dell.com>
Co-authored-by: YianZong <63342088+YianZong@users.noreply.github.com>
Co-authored-by: taohe1012 <88763781+taohe1012@users.noreply.github.com>
Co-authored-by: forrestxia <105040588+forrestxia@users.noreply.github.com>
Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@emc.com>
Co-authored-by: bjiang27 <105997542+bjiang27@users.noreply.github.com>
atye added a commit that referenced this pull request Dec 13, 2022
@atye @baoy1
@hoppea2 @shaynafinocchiaro @sharmilarama @YianZong @taohe1012 @forrestxia @EvgenyUglov @bjiang27 @tdawe
Rebase main (#161)
33a15f8 
* changes for 1.4.0 (#145) (#146)

* charts/karavi-observability: Version fix for csm-metrics-powerscale (#148)

* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <yiming.bao@emc.com>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <yiming.bao@dell.com>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <66699024+shaynafinocchiaro@users.noreply.github.com>
Co-authored-by: Sharmila Ramamoorthy <sharmila.ramamoorthy@dell.com>
Co-authored-by: YianZong <63342088+YianZong@users.noreply.github.com>
Co-authored-by: taohe1012 <88763781+taohe1012@users.noreply.github.com>
Co-authored-by: forrestxia <105040588+forrestxia@users.noreply.github.com>
Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@emc.com>
Co-authored-by: bjiang27 <105997542+bjiang27@users.noreply.github.com>

* [charts/csm-application-mobility]: Application Mobility v0.2.0 Release (#159)

* update authorization chart and image versions (#155)

Co-authored-by: baoy1 <105041111+baoy1@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <66699024+shaynafinocchiaro@users.noreply.github.com>
Co-authored-by: Sharmila Ramamoorthy <sharmila.ramamoorthy@dell.com>
Co-authored-by: YianZong <63342088+YianZong@users.noreply.github.com>
Co-authored-by: taohe1012 <88763781+taohe1012@users.noreply.github.com>
Co-authored-by: forrestxia <105040588+forrestxia@users.noreply.github.com>
Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@emc.com>
Co-authored-by: bjiang27 <105997542+bjiang27@users.noreply.github.com>
Co-authored-by: Trevor Dawe <trevor.dawe@dell.com>
sharmilarama added a commit that referenced this pull request Dec 13, 2022
@sharmilarama @hoppea2
@shaynafinocchiaro @YianZong @taohe1012 @forrestxia @atye @EvgenyUglov @baoy1 @bjiang27
charts/karavi-observability: CSM 1.5 release (#165)
8f92b22 
* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

Co-authored-by: sharmilarama <72404078+sharmilarama@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <yiming.bao@emc.com>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <yiming.bao@dell.com>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

* Update cert-manager to 1.10.0 for Observability (#151)

* update authorization sidecar image (#156)

* Update to latest images

Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <66699024+shaynafinocchiaro@users.noreply.github.com>
Co-authored-by: YianZong <63342088+YianZong@users.noreply.github.com>
Co-authored-by: taohe1012 <88763781+taohe1012@users.noreply.github.com>
Co-authored-by: forrestxia <105040588+forrestxia@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: EvgenyUglov <63835199+EvgenyUglov@users.noreply.github.com>
Co-authored-by: baoy1 <105041111+baoy1@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@emc.com>
Co-authored-by: bjiang27 <105997542+bjiang27@users.noreply.github.com>
Co-authored-by: Yiming Bao <yiming.bao@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-Cao P-Cao P-Cao approved these changes

@baoy1 baoy1 baoy1 approved these changes

@forrestxia forrestxia forrestxia approved these changes

@taohe1012 taohe1012 taohe1012 approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YianZong @shaynafinocchiaro @sharmilarama @taohe1012 @forrestxia @baoy1 @P-Cao