Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go library versions #220

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update go library versions #220

merged 1 commit into from
Mar 15, 2023

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Mar 14, 2023 •
edited
Loading

Description

Update go.mod library versions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@csmbot
Copy link
Collaborator

csmbot commented Mar 14, 2023

Can one of the admins verify this patch?

EvgenyUglov
EvgenyUglov previously approved these changes Mar 14, 2023
View reviewed changes
@xuluna xuluna changed the title Fix library vulnerability Update go library versions Mar 14, 2023
@xuluna xuluna changed the base branch from release-v1.6.0 to main March 14, 2023 19:03
@xuluna xuluna dismissed stale reviews from EvgenyUglov and shaynafinocchiaro March 14, 2023 19:03

The base branch was changed.

@xuluna xuluna closed this Mar 14, 2023
@xuluna xuluna reopened this Mar 14, 2023
@dell dell deleted a comment from xuluna Mar 15, 2023
@alikdell
Copy link
Collaborator

run e2e test

gallacher
gallacher approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - please proceed with the merge

@xuluna xuluna merged commit 11474a5 into main Mar 15, 2023
@xuluna xuluna deleted the luna/patch_security branch March 15, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher approved these changes

@alikdell alikdell alikdell approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@EvgenyUglov EvgenyUglov EvgenyUglov left review comments

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@IsaiasA1 IsaiasA1 Awaiting requested review from IsaiasA1

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xuluna @csmbot @alikdell @gallacher @EvgenyUglov @shaynafinocchiaro @sharmilarama