Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Authorization injection from installer script #88

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Jan 27, 2022

Description

This PR removes injection of CSM Authorization from the installer script and now enables CSM Authorization if the following conditions are met:

  • The proxy-authz-tokens, karavi-authorization-config, and proxy-server-root-certificate Secrets exist in the CSI PowerFlex driver namespace
  • The vxflexos-config-params ConfigMap exists in the CSI PowerFlex driver namespace

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#112

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have made corresponding changes to the documentation
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran the script to "install" CSM Observability in two different environments, 1) The CSI PowerFlex driver was already installed with CSM Authorization enabled 2) The CSI PowerFlex driver was already installed with CSM Authorization disabled. The script will enable Authorization only if the necessary secrets are in the driver namespace
  • Ran the script to "upgrade" CSM Observability with CSM Authorization enabled
  • Ran the script to "enable-authorization" in an environment where Authorization was not initially enabled when installing CSI PowerFlex and deploying CSM Observability, but the driver was later upgraded to enable Authorization.

@shaynafinocchiaro shaynafinocchiaro merged commit 71c89dc into main Feb 2, 2022
@shaynafinocchiaro shaynafinocchiaro deleted the feature-112-remove-injection branch February 2, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants