CSI Node Driver Failure Test Script #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaynafinocchiaro
requested review from
medegw01,
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof and
sharmilarama
as code owners
alikdell
reviewed
May 17, 2022
alikdell
previously approved these changes
May 18, 2022
rbo54
previously approved these changes
May 18, 2022
shaynafinocchiaro
dismissed stale reviews from rbo54, sharmilarama, and alikdell
via
995e610
sharmilarama
previously approved these changes
May 18, 2022
rbo54
previously approved these changes
May 19, 2022
| # failPodsInNS will fail the pods for a specific namespace by patching it with an unknown driver image | ||
| failPodsInNS() { | ||
| ns=$namespace | ||
| pods=$(getRunningPods) |
There was a problem hiding this comment.
Since you want pods in a specific namespace, shouldn't getRunningPods take an argument of the namespace to filter by? With many of our tests in podmon, the pod names are the same, e.g. pmtv1/podmontest-0, pmtv2/podmontest-0, ... I don't know if you will have that problem or not- your discretion.
There was a problem hiding this comment.
Hi @rbo54, the getRunningPods function does take in the namespace as an argument
shaynafinocchiaro
dismissed stale reviews from rbo54 and sharmilarama
via
c06545f
shaynafinocchiaro
force-pushed
the
feature-145-pod-failure-test
branch
from
c06545f to
c1f28ff
Compare
rbo54
previously approved these changes
May 19, 2022
alikdell
previously approved these changes
May 20, 2022
shaynafinocchiaro
force-pushed
the
feature-145-pod-failure-test
branch
from
c1f28ff to
c06545f
Compare
rbo54
approved these changes
May 20, 2022
sharmilarama
approved these changes
May 20, 2022
alikdell
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
monx.shonprotect-driver-podbranch that contains functionality to taint worker node on csi driver pod failure