add support to ignore volumeless pods by Resiliency #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikdell
requested review from
gallacher,
tdawe,
atye,
hoppea2,
coulof,
shaynafinocchiaro and
sharmilarama
as code owners
hoppea2
reviewed
Oct 4, 2022
| @@ -11,10 +11,12 @@ general: | |||
| - CVE-2021-44568 | |||
| - CVE-2022-0778 | |||
| - CVE-2022-2526 | |||
| - CVE-2022-27664 | |||
| # Disputed CVEs | |||
| - CVE-2019-1010022 | |||
There was a problem hiding this comment.
Should we take this opportunity to review this allowedList for CVEs?
There was a problem hiding this comment.
We have ubi image upgrade story, we should check in that story. I will add in acceptance criteria
atye
reviewed
Oct 4, 2022
| // podToArrayIDs returns the array IDs used by the pod, along with pvCount, and error | ||
| func (cm *PodMonitorType) podToArrayIDs(ctx context.Context, pod *v1.Pod) ([]string, int, error) { | ||
| arrayIDs := make([]string, 0) | ||
| pvlist, _ := K8sAPI.GetPersistentVolumesInPod(ctx, pod) |
There was a problem hiding this comment.
Does this return an error that is being discarded? Should it not be checked?
There was a problem hiding this comment.
Here we don't need, error will result in empty pvlist. We check for error where we need to, here for now not needed. When we add multi-array support, then we will need to check error and accordingly return error.
hoppea2
reviewed
Oct 4, 2022
shaynafinocchiaro
previously approved these changes
Oct 4, 2022
hoppea2
previously approved these changes
Oct 4, 2022
atye
previously approved these changes
Oct 4, 2022
sharmilarama
previously approved these changes
Oct 4, 2022
alikdell
dismissed stale reviews from sharmilarama, atye, and hoppea2
via
6414c50
atye
approved these changes
Oct 4, 2022
shaynafinocchiaro
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore volumeless pods with Resiliency label.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
PASS
coverage: 92.3% of statements
status 0
ok podmon/internal/monitor 8.636s coverage: 92.3% of statements