use stored mount or device count for ignorevolumeless pods for node cleanup #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikdell
requested review from
gallacher,
tdawe,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
aqu-dell and
IsaiasA1
as code owners
atye
approved these changes
Oct 12, 2022
shaynafinocchiaro
approved these changes
Oct 12, 2022
hoppea2
reviewed
Oct 12, 2022
| @@ -12,6 +12,7 @@ general: | |||
| - CVE-2022-0778 | |||
| - CVE-2022-2526 | |||
| - CVE-2022-27664 | |||
There was a problem hiding this comment.
Should CVE-2022-27664 be removed implementing the workaround found by the Yulan team?
There was a problem hiding this comment.
Yes when we implement that
rbo54
requested changes
Oct 12, 2022
|
|
||
| // ignore volumeless pods if needed | ||
| if IgnoreVolumelessPods && len(podInfo.Mounts) == 0 && len(podInfo.Devices) == 0 { | ||
| log.Infof("IgnoreVolumelessPods %t mount %d device %d", IgnoreVolumelessPods, len(podInfo.Mounts), len(podInfo.Devices)) |
There was a problem hiding this comment.
Please add the podkey to this log statement, similar to line 314 below. Otherwise good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use stored mount or device count for ignorevolumeless pods for node cleanup process.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration