Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image version consistency #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

riya-kaushal7997
Copy link
Contributor

@riya-kaushal7997 riya-kaushal7997 commented Feb 3, 2025

Description

Added support for semver.go
Set image VERSION through semver.mk and removed the unnecessary hardcoded fields

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built and tagged podman image successfully
[root@lglw3182 karavi-resiliency]# make podman
curl -O -L https://raw.githubusercontent.com/dell/csm/main/config/csm-common.mk
...
go run core/semver/semver.go -f mk >semver.mk
make -f docker.mk podman DEFAULT_GOIMAGE=golang:1.23 CSM_BASEIMAGE=quay.io/dell/container-storage-modules/csm-base-image:nightly
make[1]: Entering directory '/root/riya/image_version_test/karavi-resiliency'
MAJOR 1 MINOR 12 PATCH 0 RELNOTE  SEMVER 1.12.0+3+dirty
podman build --pull --no-cache -t ""10.247.98.98:5000/podmon":"v1.12.0"" --build-arg GOIMAGE=golang:1.23 --build-arg BASEIMAGE=quay.io/dell/container-storage-modules/csm-base-image:nightly -f ./Dockerfile --label commit=0bf43a6e2aeef70fd0f15584592a5f17b923cfc7 .
[1/2] STEP 1/4: FROM golang:1.23 AS builder
...
[2/2] COMMIT 10.247.98.98:5000/podmon:v1.12.0
--> bdf9c71bf1b4
Successfully tagged 10.247.98.98:5000/podmon:v1.12.0
bdf9c71bf1b4e3cc1ebe5cc034af109131a29837c97fe42b951a9be3e94da5b9
make[1]: Leaving directory '/root/riya/image_version_test/karavi-resiliency'

@riya-kaushal7997 riya-kaushal7997 marked this pull request as ready for review February 3, 2025 13:16
core/core.go Outdated Show resolved Hide resolved
docker.mk Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants