Skip to content

Commit

Permalink
Replace docker build with podman build (#157)
Browse files Browse the repository at this point in the history
* replace docker build with podman build

* update codeowners
  • Loading branch information
chimanjain authored Sep 19, 2024
1 parent 8983e49 commit 90581e4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
13 changes: 7 additions & 6 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,23 @@
# be requested for review when someone opens a pull request.
# order is alphabetical for easier maintenance.
#
# Sean Gallacher (gallacher)
# Trevor Dawe (tdawe)
# AnandatDell (anandrajak1)
# Alexander Hoppe (hoppea2)
# Alik Saring (alikdell)
# Aaron Tye (atye)
# Chiman Jain (chimanjain)
# Don Khan (donatwork)
# Florian Coulombel (coulof)
# Nitesh Rewatkar (nitesh3108)
# Sean Gallacher (gallacher)
# Shayna Finocchiaro (shaynafinocchiaro)
# Sharmila Ramamoorthy (sharmilarama)
# Forrest Xia (forrestxia)
# Trevor Dawe (tdawe)
# Yian Zong (YianZong)
# Yiming Bao (baoy1)
# Tao He (taohe1012)
# Peter Cao (P-Cao)
# Don Khan (donatwork)
# Harsha Yalamanchili (harshaatdell)
# AnandatDell (anandrajak1)

# for all files:
* @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @sharmilarama @forrestxia @YianZong @baoy1 @taohe1012 @P-Cao @donatwork @harshaatdell @anandrajak1
* @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @sharmilarama @forrestxia @YianZong @baoy1 @taohe1012 @P-Cao @donatwork @anandrajak1 @chimanjain @nitesh3108
17 changes: 9 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ help:
@echo
@echo "build - Builds the code locally"
@echo "clean - Cleans the local build"
@echo "docker - Builds Docker image"
@echo "tag - Tags Docker image"
@echo "push - Pushes Docker image to a registry"
@echo "podman - Builds Podman image"
@echo "tag - Tags Podman image"
@echo "push - Pushes Podman image to a registry"
@echo "check - Runs code checking tools: lint, format, gosec, and vet"
@echo "test - Runs the unit tests"
@echo
Expand Down Expand Up @@ -38,17 +38,18 @@ build-base-image: download-csm-common
@echo "Base image build: SUCCESS"
$(eval BASEIMAGE=topology-ubimicro:latest)

.PHONY: docker
docker: build-base-image
docker build -t csm-topology -f Dockerfile --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .
# Pre-requisites: RHEL, buildah, podman
.PHONY: podman
podman: build-base-image
podman build -t csm-topology -f Dockerfile --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .

.PHONY: tag
tag:
docker tag csm-topology:latest ${DOCKER_REPO}/csm-topology:latest
podman tag csm-topology:latest ${DOCKER_REPO}/csm-topology:latest

.PHONY: push
push:
docker push ${DOCKER_REPO}/csm-topology:latest
podman push ${DOCKER_REPO}/csm-topology:latest

.PHONY: check
check:
Expand Down

0 comments on commit 90581e4

Please sign in to comment.