Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ubi-micro image #132

Merged
merged 2 commits into from
May 8, 2023
Merged

update ubi-micro image #132

merged 2 commits into from
May 8, 2023

Conversation

EmilyKatdell
Copy link
Contributor

@EmilyKatdell EmilyKatdell commented May 4, 2023 •
edited by harshaatdell
Loading

Description

Update ubi micro image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
922

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Manual testing was done

@EmilyKatdell
Copy link
Contributor Author

run e2e test

donatwork
donatwork previously approved these changes May 4, 2023
View reviewed changes
santhoshatdell
santhoshatdell previously approved these changes May 4, 2023
View reviewed changes
hoppea2
hoppea2 reviewed May 5, 2023
View reviewed changes
Copy link
Collaborator

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilyKatdell Let's add some Phoenix folks as code owners so that their reviews approve the PR https://github.com/dell/karavi-topology/blob/main/.github/CODEOWNERS

@EmilyKatdell EmilyKatdell dismissed stale reviews from santhoshatdell and donatwork via 3035940 May 8, 2023 16:35
EmilyKatdell
EmilyKatdell commented May 8, 2023
View reviewed changes
Copy link
Contributor Author

@EmilyKatdell EmilyKatdell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run e2e test pass

@hoppea2 hoppea2 merged commit 20947ee into main May 8, 2023
@hoppea2 hoppea2 deleted the Use-ubi-micro-image branch May 8, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@gallacher gallacher Awaiting requested review from gallacher

@tdawe tdawe Awaiting requested review from tdawe

@alikdell alikdell Awaiting requested review from alikdell

@atye atye Awaiting requested review from atye atye is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

@forrestxia forrestxia Awaiting requested review from forrestxia

@YianZong YianZong Awaiting requested review from YianZong

@baoy1 baoy1 Awaiting requested review from baoy1

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilyKatdell @donatwork @hoppea2 @santhoshatdell