Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preflight required labels. #183

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

donatwork
Copy link
Contributor

Description

Added the required labels to the image container so that it can pass preflight checks.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1667

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Built image. Docker inspect shows:

{
"architecture": "x86_64",
"build-date": "2024-08-27T19:24:54",
"com.redhat.component": "ubi9-micro-container",
"com.redhat.license_terms": "https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI",
"description": "Provides Kubernetes administrators with the topology data related to containerized storage that is provisioned by CSI (Container Storage Interface) Drivers for Dell storage products",
"distribution-scope": "public",
"io.buildah.version": "1.29.4",
"io.k8s.description": "Very small image which doesn't install the package manager.",
"io.k8s.display-name": "Ubi9-micro",
"io.openshift.expose-services": "",
"license": "Apache-2.0",
"maintainer": "Dell Technologies",
"name": "csm-topology",
"release": "1.13.0",
"summary": "Dell Container Storage Modules (CSM) for Observability - Metrics for Topology",
"url": "https://access.redhat.com/containers/#/registry.access.redhat.com/ubi9/ubi-micro/images/9.4-15",
"vcs-ref": "cd5996c9b8b99b546584696465f8f39ec682078c",
"vcs-type": "git",
"vendor": "Dell Technologies",
"version": "2.0.0"
}

Dockerfile Outdated
name="csm-topology" \
summary="Dell Container Storage Modules (CSM) for Observability - Metrics for Topology" \
description="Provides Kubernetes administrators with the topology data related to containerized storage that is provisioned by CSI (Container Storage Interface) Drivers for Dell storage products" \
release="1.13.0" \
version="2.0.0" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donatwork Can we update version here, otherwise it looks prefect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version to 1.11.0

@chimanjain chimanjain merged commit bc79f74 into main Jan 9, 2025
8 checks passed
@chimanjain chimanjain deleted the usr/dkhan/preflight-update branch January 9, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants