[fix] Fast-EM optical autofocus tests #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepals
changed the title
nandishjpatel
approved these changes
Jul 25, 2024
pieleric
requested changes
Jul 25, 2024
tepals
force-pushed
the
SDEV-1899-fix-optical-autofocus-tests
branch
from
719abad
to
06f7c56
Compare
pieleric
requested changes
Aug 29, 2024
…psize is reached Break the loop after moving to the best position: Otherwise the focus will not be at the best position when clipping left and right have caused left and right to be equal, but them not being equal to the center / best position.
tepals
force-pushed
the
SDEV-1899-fix-optical-autofocus-tests
branch
2 times, most recently
from
5a4f448
to
aa9ce02
Compare
|
I've split the PR into two and left the autofocus fix here, that part should be ready to review. I moved the other commits to a different branch, to look into at a later stage. |
tepals
added a commit
to tepals/odemis
that referenced
this pull request
Nov 15, 2024
branched off of: delmic#2840
pieleric
approved these changes
Nov 18, 2024
nandishjpatel
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in the binary autofocusing algorithm that caused the optical autofocus to fail.