[fix] correct the check to find which axes are requested to move. #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it takes into account if the requested move is relative or not, to compare axes properly
K4rishma
requested review from
pieleric,
patrickcleeve2 and
nandishjpatel
and removed request for
patrickcleeve2
patrickcleeve2
approved these changes
Nov 21, 2024
| # Drop axes from the original position, which are not important because they have not moved | ||
| orig_pos = {a: orig_pos[a] for a, nv in pos.items() if nv != orig_pos[a]} | ||
| orig_pos = {a: orig_pos[a] for a, nv in target_pos.items() if nv != orig_pos[a]} |
There was a problem hiding this comment.
Do you really need this? At line 2327 one is already requesting a move to pos stating its rel. Maybe the time.sleep(0.1) is not enough in some cases?
There was a problem hiding this comment.
We need orig position a bit later when we start checking if the stage has moved to the requested position. Does that answer your question?
nandishjpatel
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it correctly takes into account if the requested move is relative or not, to compare the axes