Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visitor for converting kernel expressions to engine expressions #358

Open
zachschuermann opened this issue Sep 25, 2024 · 0 comments · May be fixed by #363
Open

Add visitor for converting kernel expressions to engine expressions #358

zachschuermann opened this issue Sep 25, 2024 · 0 comments · May be fixed by #363
Assignees
@OussamaSaoudi-db

Comments

@zachschuermann
Copy link
Collaborator

  1. Move the existing schema visitor stuff to its own module (probably schema.rs)
  2. Move the existing expression visitor which does engine_predicate -> kernel_expression into an "expressions" module
  3. Add code for a visitor similar to the schema visitor but for expressions that let's us do kernel_expression -> engine_expression
This was referenced Sep 27, 2024
Merged
Open
OussamaSaoudi-db added a commit that referenced this issue Oct 7, 2024
@OussamaSaoudi-db
Move schema and expression FFI code to separate module (#360)
135e8d3 
This PR addresses points 1 & 2 in #358 by moving the `EngineSchemaVisitor` to
the `ffi/src/schema.rs` module, and moving the `KernelExpressionVisitor` to the
module `ffi/src/expressions.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OussamaSaoudi-db OussamaSaoudi-db

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add visitor for converting kernel expressions to engine expressions OussamaSaoudi-db/delta-kernel-rs
2 participants
@zachschuermann @OussamaSaoudi-db