Add support for presigned-url reading to the default client #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
force-pushed
the
presigned-url-fetching
branch
from
c1b35a3
to
ab7f552
Compare
zachschuermann
approved these changes
Apr 24, 2024
| rbr.map_err(Error::Arrow) | ||
| .and_then(|rb| reorder_record_batch(rb, &requested_ordering)) | ||
| }); | ||
| Ok(stream.boxed()) |
There was a problem hiding this comment.
for the code above don't we do this elsewhere? can we reuse? maybe i'm missing something but i had the feeling this exists elsewhere
There was a problem hiding this comment.
yeah, it's similar to the code in the ParquetOpener. But that uses a ParquetRecordBatchStreamBuilder and this uses a ParquetRecordBatchReaderBuilder. They have a common trait, but you'll notice that the build method is defined uniquely depending on the sync vs. async, and since we have both the types get really gross if you try and make this code shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most non-testing code from hackathon. Most code taken from #144. It supports:
filesysteminterface from http/httpsCurrently working on how best to test this since we can't have stable urls to read from