Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] write path prototype #319

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Aug 27, 2024

Write path prototype for supporting blind appends. Major pieces:

  • Transaction: an in-progress write to a table. follows a builder-type pattern to add writes and in the future stage deletes, evolve schema/metadata, etc.
  • WriteContext: everything executor needs to write data
  • an API layer for communicating 'write metadata': every executor returns data about the write which is passed to Txn.add_write_metadata(...) to stage the writes for commit. (naming TODO)
  • Engine API: JsonHandler::put_json

Open questions/TODOs:

  • can we stream commits? so that the write_metadata passed back to the transaction is effectively streamed into the commit in order to prevent forcing the engine to materialize all actions into memory at once
  • main thread -> executor boundary: do we want to communicate write_context as EngineData?
  • need to move a bunch of engine code from the write test into default engine.

@zachschuermann zachschuermann self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant