[WIP] Improve casting support in nested maps/arrays #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: this was part of a time-boxed hackathon, I didn't get time to bring it to a more polished state or test this code properly. Publishing in case it's useful to anyone, feel free to reuse (at your own risks).
This includes changes from #335.
The actual relevant part here is the 2nd commit: 7159dc1
Type widening requires casting values on read after a type change is applied to a table, from the narrower parquet type to the current wider type in the table schema.
This change aims at fixing issues and limitations with casting inside arrays and maps