Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples (and appease clippy) #376

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

zachschuermann
Copy link
Collaborator

some quick fixes for both examples and a quick clippy fix for docstring

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (86ffe02) to head (8893d3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files          47       47           
  Lines        9436     9436           
  Branches     9436     9436           
=======================================
  Hits         7253     7253           
  Misses       1789     1789           
  Partials      394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachschuermann zachschuermann merged commit 1e19980 into delta-incubator:main Oct 8, 2024
12 checks passed
@zachschuermann zachschuermann deleted the fix-examples branch October 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants