Skip to content

Commit

Permalink
chore: pin ruff and mypy versions in the lint stage in the CI p…
Browse files Browse the repository at this point in the history
…ipeline (#2679)

Currently, `ruff` and `mypy` have their latest versions installed in the
CI pipeline, while locally they are fixed to a specific version. This
can cause issues, see #2678.

This PR proposes to fix them to their specific version in the pipeline.
The alternative I could think of was installing the virtual environment
with `make develop`, but that takes between 4 and 5 minutes, which might
be considered a bit too long to wait on linting results.

This PR will have conflicts with
#2674, so I'll need to rebase
one of these PR's once the other is merged.

# Related Issue(s)

- closes [#106](#2678)
  • Loading branch information
fpgmaas authored Jul 18, 2024
1 parent ab977e3 commit 30bab74
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/python_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: "3.10"

- name: Check Python
run: |
pip install ruff black mypy types-dataclasses typing-extensions
pip install ruff==0.5.2 mypy==1.10.1 types-dataclasses typing-extensions
make check-python
- name: Install minimal stable with clippy and rustfmt
Expand Down
7 changes: 4 additions & 3 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ pandas = [
]
devel = [
"azure-storage-blob==12.20.0",
"mypy~=1.8.0",
"ruff~=0.5.2",
"packaging>=20",
"pytest",
"pytest-mock",
Expand All @@ -39,7 +37,10 @@ devel = [
"sphinx-rtd-theme",
"toml",
"wheel",
"pytest-benchmark"
"pytest-benchmark",
# keep ruff and mypy versions in sync with .github/workflows/python_build.yml
"mypy==1.10.1",
"ruff==0.5.2"
]
pyspark = [
"pyspark",
Expand Down

0 comments on commit 30bab74

Please sign in to comment.