Skip to content

Commit

Permalink
Loosen version requirement for maturin (#1005)
Browse files Browse the repository at this point in the history
# Description

This loosen the version requirement for maturin when building the python
package.

# Related Issue(s)

- closes #1004
<!---
For example:

- closes #106
--->

# Documentation

Using an exact version can be excessively restrictive, for example
preventing the use of the latest (but still compatible) version of
maturin. Especially when packaging for rolling-releases distributions
(like Archlinux), being able to build with the latest version would be
beneficial.
<!---
Share links to useful documentation
--->
  • Loading branch information
gyscos authored Dec 9, 2022
1 parent 8d45ea4 commit e0f953b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions python/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.DEFAULT_GOAL := help

VENV := venv
MATURIN_VERSION := $(shell awk -F '[ ="]+' '$$1 == "requires" { print $$4 }' pyproject.toml)
MATURIN_VERSION := $(shell grep 'requires =' pyproject.toml | cut -d= -f2- | tr -d '[ "]')
PACKAGE_VERSION := $(shell grep version Cargo.toml | head -n 1 | awk '{print $$3}' | tr -d '"' )

.PHONY: setup-venv
Expand All @@ -12,7 +12,7 @@ setup-venv: ## Setup the virtualenv
.PHONY: setup
setup: ## Setup the requirements
$(info --- Setup dependencies ---)
pip install maturin==$(MATURIN_VERSION)
pip install "$(MATURIN_VERSION)"

.PHONY: build
build: setup ## Build Python binding of delta-rs
Expand Down
4 changes: 2 additions & 2 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["maturin==0.14.2"]
requires = ["maturin>=0.14,<0.15"]
build-backend = "maturin"

[project]
Expand Down Expand Up @@ -82,4 +82,4 @@ markers = [
"azure: marks tests as integration tests with Azure Blob Store",
"pandas: marks tests that require pandas",
"pyspark: marks tests that require pyspark",
]
]

0 comments on commit e0f953b

Please sign in to comment.