Skip to content

Commit

Permalink
Change private time_utils module to public. (#586)
Browse files Browse the repository at this point in the history
* Change private time_utils module to public.

* Temporarily disable lambda test in CI.
  • Loading branch information
xianwill authored Apr 19, 2022
1 parent 54da787 commit fca5931
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 28 deletions.
54 changes: 27 additions & 27 deletions .github/workflows/lambda_checkpoint_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,31 +35,31 @@ jobs:
- name: build and lint with clippy
run: cargo clippy -p lambda-delta-checkpoint


test:
strategy:
fail-fast: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Build musl
uses: docker://messense/rust-musl-cross:x86_64-musl
with:
args: cargo build -p lambda-delta-checkpoint
- name: Zip lambda bin
run: |
zip -j lambda-delta-checkpoint.zip ./target/x86_64-unknown-linux-musl/debug/bootstrap
- name: Setup localstack
run: |
cp lambda-delta-checkpoint.zip ./aws/delta-checkpoint/
docker network create delta-checkpoint
(cd ./aws/delta-checkpoint && docker-compose up setup)
- name: Run tests
run: |
docker run --rm \
--network delta-checkpoint \
--env "AWS_ENDPOINT_URL=http://localstack:4566" \
-v "$(pwd)":/home/rust/src \
messense/rust-musl-cross:x86_64-musl \
cargo test -p lambda-delta-checkpoint
## Temporarily disable test - the lambda isn't super useful with the current checkpoint memory pressure anyway.
# test:
# strategy:
# fail-fast: false
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - name: Build musl
# uses: docker://messense/rust-musl-cross:x86_64-musl
# with:
# args: cargo build -p lambda-delta-checkpoint
# - name: Zip lambda bin
# run: |
# zip -j lambda-delta-checkpoint.zip ./target/x86_64-unknown-linux-musl/debug/bootstrap
# - name: Setup localstack
# run: |
# cp lambda-delta-checkpoint.zip ./aws/delta-checkpoint/
# docker network create delta-checkpoint
# (cd ./aws/delta-checkpoint && docker-compose up setup)
# - name: Run tests
# run: |
# docker run --rm \
# --network delta-checkpoint \
# --env "AWS_ENDPOINT_URL=http://localstack:4566" \
# -v "$(pwd)":/home/rust/src \
# messense/rust-musl-cross:x86_64-musl \
# cargo test -p lambda-delta-checkpoint

2 changes: 1 addition & 1 deletion rust/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ pub mod partitions;
pub mod schema;
pub mod storage;
mod table_state;
mod time_utils;
pub mod time_utils;
pub mod writer;

#[cfg(feature = "datafusion-ext")]
Expand Down
2 changes: 2 additions & 0 deletions rust/src/time_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//! Utility functions for converting time formats.
use arrow::temporal_conversions;
use parquet_format::TimeUnit;

Expand Down

0 comments on commit fca5931

Please sign in to comment.