Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor commit interface to be a Builder #2131

Closed
Blajda opened this issue Jan 28, 2024 · 1 comment · Fixed by #2154
Closed

Refactor commit interface to be a Builder #2131

Blajda opened this issue Jan 28, 2024 · 1 comment · Fixed by #2154
Assignees
@hntd187 @Blajda
Labels
binding/rust Issues for the Rust crate enhancement New feature or request

Comments

@Blajda
Copy link
Collaborator

Blajda commented Jan 28, 2024

Description

Currently commit is not a builder which results in a brittle interface whenever new commit options are added. Refactor to be a builder so code changes are isolated to the module and don't require updates in all operations.

Operation should be updated to delegate to this builder but must keep some members like log_store and operation private.

Related Issue(s)
#2130 - Implementing Txn identifiers would require adding a new parameter to the current function and break various call sites.
@Blajda Blajda added enhancement New feature or request binding/rust Issues for the Rust crate labels Jan 28, 2024
@hntd187
Copy link
Collaborator

hntd187 commented Jan 31, 2024

take

@Blajda Blajda self-assigned this Jan 31, 2024
@Blajda Blajda mentioned this issue Feb 1, 2024
Merged
Blajda added a commit that referenced this issue Mar 14, 2024
@Blajda
refactor!: use builder for commit interface (#2154)
67df4cb 
# Description
Refactor the commit function to instead be accessed through a builder
interface to prevent breaking call sites when new commit attributes are
added.

This also introduces a new public struct called `CommitProperties` to be
used by any delta operation and to ensure a consistent interface for end
users. With this change we should break usage of `app_metadata` on
operations and instead have users use this struct.

# Related Issue(s)
- closes: #2131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hntd187 hntd187

@Blajda Blajda

Labels
binding/rust Issues for the Rust crate enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: use builder for commit interface Blajda/delta-rs
2 participants
@hntd187 @Blajda