Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deltalake-core version re-exported by deltalake different than versions used by deltalake-azure and deltalake-gcp #2647

Closed
kyle-mccarthy opened this issue Jul 3, 2024 · 3 comments · Fixed by #2648
Assignees
Labels
binding/rust Issues for the Rust crate bug Something isn't working

Comments

@kyle-mccarthy
Copy link

Environment

Delta-rs version: 0.18

Binding: Rust

Environment:

  • Cloud provider: azure, gcp
  • OS: macos
  • Other: Default registry (crates.io)

Bug

What happened: azure and gcp features use different deltalake-core version than one re-exported by the deltalake crate. This makes the azure and gcp crates use a different static registry than the re-exported registry, breaking registration of cloud provider specific factories.

What you expected to happen: Same version of `deltalake-core' to be used so factories can be registered under their cloud specific schemes.

How to reproduce it: Create a fresh project and add deltalake v0.18 with the azure feature enabled. Note that crates.io should be used as the registry rather than git or path.

[package]
name = "repro"
version = "0.1.0"
edition = "2021"

[dependencies]
deltalake = { version = "0.18", features = ["azure"] }

More details:

  • Affects versions following 0.17.3.
  • Breaks factory registration for cloud provider URL schemes:
fn main() {
    deltalake::azure::register_handlers(None);

    let registered_factories = deltalake::storage::factories()
        .iter()
        .map(|entry| entry.key().to_owned())
        .collect::<Vec<_>>();

    dbg!(registered_factories); // only includes the default file and memory schemes
}
  • deltalake v0.18.1 uses deltalake-core v0.18.1 and deltalake-azure v0.1.2. deltalake-azure v0.1.2 uses deltalake-core v0.17.3.
❯ cargo tree --depth 3
repro v0.1.0 (/Users/me/workspaces/repro)
└── deltalake v0.18.1
    ├── deltalake-azure v0.1.2
    │   ├── deltalake-core v0.17.3
    │   ├── ...
    └── deltalake-core v0.18.1
        ...
  • Happens with both the azure and gcp features. aws appears to be broken entirely as enabling the feature causes the crate's build to fail.
@kyle-mccarthy kyle-mccarthy added the bug Something isn't working label Jul 3, 2024
@rtyler
Copy link
Member

rtyler commented Jul 3, 2024

I think you managed to file this shortly after @mightyshazam and I diagnosed this in Slack 😆

Use deltalake-azure ~> 0.1.3

I'm guessing I need to rev the version and release deltalake-gcp with the more correct version constraints

@rtyler rtyler self-assigned this Jul 3, 2024
@rtyler rtyler added the binding/rust Issues for the Rust crate label Jul 3, 2024
@rtyler
Copy link
Member

rtyler commented Jul 3, 2024

deltalake-gcp 0.2.2 has been pushed as well with the right version ranges.

Can you verify that your troubles have been remedied @kyle-mccarthy ?

@kyle-mccarthy
Copy link
Author

@rtyler that seems to have fixed it! thanks!

--

Note for future readers, make sure to run cargo update to fetch the updated crates.io index.

roeap added a commit that referenced this issue Jul 7, 2024
I already cut releases of these to crates.io since I forgot to push
updates after we cleaned up the version declarations on deltalake-core a
while back.


Fixes #2647

---------

Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants