Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_latest_version method should return version >= 0 #312

Closed
houqp opened this issue Jul 11, 2021 · 0 comments · Fixed by #364
Closed

get_latest_version method should return version >= 0 #312

houqp opened this issue Jul 11, 2021 · 0 comments · Fixed by #364
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Jul 11, 2021

Environment

Delta-rs version: all

Binding: Rust

Bug

What happened:

For an empty directory, DeltaTable.get_latest_version could return version -1.

What you expected to happen:

It should return an error instead, potentially DeltaTableError::NotATable.
@houqp houqp added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers binding/rust Issues for the Rust crate labels Jul 11, 2021
@houqp houqp mentioned this issue Jul 11, 2021
Merged
@zijie0 zijie0 mentioned this issue Aug 9, 2021
Merged
@houqp houqp closed this as completed in #364 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get_latest_version returning version < 0. zijie0/delta-rs
1 participant
@houqp