Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_latest_version returning version < 0. #364

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

zijie0
Copy link
Contributor

@zijie0 zijie0 commented Aug 9, 2021

Description

Fix an edge case in get_latest_version.

Related Issue(s)

Documentation

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houqp houqp merged commit 4fd43cb into delta-io:main Aug 9, 2021
@houqp
Copy link
Member

houqp commented Aug 9, 2021

Thanks @zijie0 , looks like you are getting very proficient with Rust already ;)

@zijie0
Copy link
Contributor Author

zijie0 commented Aug 9, 2021

@houqp Thanks, I'm feeling good to learn a new language through contributing to a real project. And we are using delta-rs in our data platform heavily to support high performance data consumption. Great job!

@zijie0 zijie0 deleted the fix_get_latest_version branch August 9, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_latest_version method should return version >= 0
2 participants