Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap DeltaTransactionError with DeltaTableError #346

Closed
houqp opened this issue Aug 2, 2021 · 0 comments · Fixed by #374
Closed

Wrap DeltaTransactionError with DeltaTableError #346

houqp opened this issue Aug 2, 2021 · 0 comments · Fixed by #374
Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Aug 2, 2021

Description

Use Case

Today, DeltaTableError is wrapped as an enum variant in DeltaTransactionError, which forced some of the DeltaTable methods to return DeltaTransactionError as the error type. I think things would be cleaner if we change the abstraction to have DeltaTableError wrapping DeltaTransactionError instead.

Related Issue(s)

From discussion in #342 (comment)
@houqp houqp added enhancement New feature or request binding/rust Issues for the Rust crate good first issue Good for newcomers help wanted Extra attention is needed labels Aug 2, 2021
@houqp houqp mentioned this issue Aug 2, 2021
Merged
@zijie0 zijie0 mentioned this issue Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap DeltaTransactionError with DeltaTableError. zijie0/delta-rs
1 participant
@houqp