Low level create table #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for create table
need to fix test cleanup need to add logic to make create() safer want to return an updated DeltaTable (new state) after a create() is successful
houqp
reviewed
Jul 31, 2021
houqp
reviewed
Jul 31, 2021
fvaleye
reviewed
Jul 31, 2021
fvaleye
reviewed
Jul 31, 2021
fvaleye
reviewed
Jul 31, 2021
fvaleye
reviewed
Jul 31, 2021
fvaleye
reviewed
Jul 31, 2021
…in the test. Still need to do better error handling in the create() method and figure out how to create a _last_checkpoint and update the DeltaTableState
… how to handle possible errors in the create() method
Smurphy000
commented
Aug 1, 2021
…sing cloned actions, can now update the DeltaTable state after the commit portion of create() method
added more asserts for test
|
@Smurphy000 could you help manually resolve the comments you already addressed with follow up commits? That will make it a little bit easier for us to do follow up reviews :) |
updated new DeltaTableMetadata to take in a format option change create method resulting Error type to be a transaction error
houqp
reviewed
Aug 3, 2021
as suggested by houqp Co-authored-by: QP Hou <dave2008713@gmail.com>
houqp
reviewed
Aug 3, 2021
…for the data actually written to the delta table from the create method
|
Thank you @Smurphy000, I hope you had a good time hacking on rust and delta ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the current implementation for a low level create table api
Looking for feedback