Fix to support UTC timezone #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-ionescu
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
|
Thanks for your PR @andrei-ionescu 👍 Could you please add a unit-test to better describe the issue fixed? |
andrei-ionescu
force-pushed
the
fix_to_support_utc
branch
from
6728aeb
to
7667c98
Compare
|
@fvaleye I added a few tests on the timestamp date type, both ways. I did not add negative tests for other timezones as we may want to support all timezones. I'm not sure why some of the checks do fail. It shows linting errors on files I did not touch at all. Is this a know issue? |
This is a quite common occurrence whenever new versions of rust, and with that new clippy rules in cargo get released. And 1.66 just got released.. |
wjones127
previously approved these changes
Dec 21, 2022
fvaleye
previously approved these changes
Dec 21, 2022
Related to delta-io#1019
wjones127
force-pushed
the
fix_to_support_utc
branch
from
7667c98
to
9dc51fb
Compare
wjones127
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for UTC timezone.
Related Issue(s)
Documentation