refactor(api!): refactor Python APIs for getting file list #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
force-pushed
the
fix/revert-uris
branch
from
9d41215 to
0b2d086
Compare
wjones127
requested review from
fvaleye,
rtyler,
roeap and
houqp
as code owners
fvaleye
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the four methods
files(),file_paths(),file_uris(),files_by_partitions()into just two methods:files()-> which returns paths as they are in the Delta Log (usually relative, but can be absolute, particularly if they are located outside of the delta table root).file_uris(), which returns absolute URIs for all files.Both of these now take the
partition_filtersparameter, makingfiles_by_partitions()obsolete. That latter function has been marked deprecated, but it also returns it to its original behavior of returning absolute file paths and not relative ones, resolving #894.Finally, the
partition_filtersparameter now supports passing values other than strings, such as integers and floats.TODO:
Test behavior of filtering for null or non-nullNull handling isn't supported by DNF filters IIUCRelated Issue(s)
Documentation