feat: improve storage location handling #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
rtyler and
mosyp
as code owners
houqp
approved these changes
Jan 15, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description This PR contains some improvements and refactoring for handling storage locations. - Removes the `StorageLocation` struct (a left-over from previous clean up) - allows for creating tables using local file paths (including relative) - persists options during serialization (this will not work for custom storage backends, but still extends what the previous approach could do) - adopts `PrefixObjectStore` from upstream crate in favour of maintaining that logic here. - run `cargo clippy --fix` on `/rust` # Related Issue(s) Closes delta-io#998 # Documentation <!--- Share links to useful documentation --->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains some improvements and refactoring for handling storage locations.
StorageLocationstruct (a left-over from previous clean up)PrefixObjectStorefrom upstream crate in favour of maintaining that logic here.cargo clippy --fixon/rustRelated Issue(s)
Closes #998
Documentation