Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of writing to a delta table with a RecordBatch #1085

Merged
merged 5 commits into from
Jan 28, 2023

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jan 21, 2023

No description provided.

@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Jan 21, 2023
@johnbatty
Copy link
Contributor

This looks awesome.

I'm new to delta-rs and have been frustrated by lack of examples demonstrating how to write to tables from Rust. This is exactly what I wanted! 🚀

Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! It's good to see examples to understand the state of our APIs.

rust/examples/recordbatch-writer.rs Outdated Show resolved Hide resolved
rust/examples/recordbatch-writer.rs Outdated Show resolved Hide resolved
rtyler and others added 2 commits January 21, 2023 21:32
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
@rtyler
Copy link
Member Author

rtyler commented Jan 24, 2023

@wjones127 I've committed the suggestions, anything else?

@rtyler rtyler enabled auto-merge (rebase) January 24, 2023 18:30
@wjones127
Copy link
Collaborator

@wjones127 I've committed the suggestions, anything else?

I'm afraid my suggestions weren't complete in themselves, so some modifications are needed to get it to compile. I can provide more suggestions if needed.

create_initialized_table(&table_path).await
},
Err(err) => {
err.unwra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@wjones127 wjones127 self-requested a review January 28, 2023 18:23
wjones127
wjones127 previously approved these changes Jan 28, 2023
@rtyler rtyler merged commit aecccba into main Jan 28, 2023
@rtyler rtyler deleted the recordbatch-writer-example branch January 28, 2023 19:20
@wjones127
Copy link
Collaborator

Thanks @rtyler !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants