Selectively overwrite data with python #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismoshkov
requested review from
wjones127,
fvaleye,
rtyler,
roeap and
houqp
as code owners
wjones127
requested changes
Jan 26, 2023
wjones127
requested changes
Jan 28, 2023
ismoshkov
force-pushed
the
python-partition-overwrite
branch
from
ad8e2ff to
108ac88
Compare
wjones127
requested changes
Feb 23, 2023
There was a problem hiding this comment.
Thank you for refactoring the tests and adding more. They look good.
I think we can use the existing DeltaJSONEncoder and then fix some other small issues and we are good-to-go.
Could you make sure to rebase and re-run make format. We just changed our linter to ruff so there may be some new rules enabled :)
added 6 commits
February 25, 2023 13:33
# Conflicts: # python/tests/test_writer.py
# Conflicts: # python/tests/test_writer.py
* simplify parametrized test * add test cases
ismoshkov
force-pushed
the
python-partition-overwrite
branch
from
108ac88 to
48e8737
Compare
wjones127
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Excellent! I'm excited for when we release this :)
Thanks @ismoshkov!
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description Currently high-level python writer isn't support partial partition overwrite. This PR enable usage of partitions filtering for writing data The functionlity is similar to: https://docs.databricks.com/delta/selective-overwrite.html The logic checks that data should contains only partitions that passing filtering. # Documentation ```python write_deltalake( delta_path, sample_data, mode="overwrite", partitions_filters=[("partition_a", ">", "1")], ) ``` --------- Co-authored-by: Ilya Moshkov <ilya.moshkov@exosfinancial.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently high-level python writer isn't support partial partition overwrite.
This PR enable usage of partitions filtering for writing data
The functionlity is similar to:
https://docs.databricks.com/delta/selective-overwrite.html
The logic checks that data should contains only partitions that passing filtering.
Documentation