chore: clippy #1106
Merged
chore: clippy #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
wjones127,
fvaleye,
rtyler,
houqp,
xianwill and
mosyp
as code owners
github-actions
bot
added
binding/python
roeap
commented
Jan 27, 2023
rust/src/writer/mod.rs
Outdated
Comment on lines
61
to
62
| #[from] | ||
| stats: serde_json::Error, |
There was a problem hiding this comment.
This is the only manual change. Clippy was complaining that the error variant was much larger then all the others. I felt forwarding the error rather then the actual data that caused the error is a reasonable change.
There was a problem hiding this comment.
That seems fair. The other option is to Box the Stats, but I think the serde_json error should be sufficient.
Could we update the doc comment above, though?
There was a problem hiding this comment.
Of course! Going forward we way consider lifting the docs requirement for error variants. I feel the error description text and variant name are usually expressive enough.
wjones127
approved these changes
Jan 27, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
# Description The latest rust release comes with new more opinionated clippy :). This PR fixes the new clippy errors and and runs `cargo clippy --fix` on all our crates. # Related Issue(s) <!--- For example: - closes delta-io#106 ---> # Documentation <!--- Share links to useful documentation --->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest rust release comes with new more opinionated clippy :). This PR fixes the new clippy errors and and runs
cargo clippy --fixon all our crates.Related Issue(s)
Documentation