Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): update docs #1155

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Conversation

wjones127
Copy link
Collaborator

@wjones127 wjones127 commented Feb 18, 2023

Description

The description of the main changes of your pull request

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package documentation Improvements or additions to documentation labels Feb 18, 2023
@roeap
Copy link
Collaborator

roeap commented Feb 18, 2023

Just went through our issues, and I guess we can close #373, once this is merged.

@wjones127 wjones127 force-pushed the update-python-docs branch from 62cf21e to d5c4b87 Compare March 1, 2023 04:45
@@ -585,7 +585,7 @@ def test_partition_overwrite(
tmp_path,
sample_data,
mode="overwrite",
partitions_filters=[("p1", "=", "1")],
partition_filters=[("p1", "=", "1")],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't yet released with this feature, so this API change should be fine.

@wjones127 wjones127 marked this pull request as ready for review March 1, 2023 15:30
roeap
roeap previously approved these changes Mar 3, 2023
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent update!

python/deltalake/writer.py Outdated Show resolved Hide resolved
Comment on lines -381 to -384
.. warning::
The writer is currently *experimental*. Please use on test data first, not
on production data. Report any issues at https://github.com/delta-io/delta-rs/issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
@wjones127 wjones127 enabled auto-merge (squash) March 3, 2023 21:31
@wjones127 wjones127 merged commit 88bdb55 into delta-io:main Mar 3, 2023
chitralverma pushed a commit to chitralverma/delta-rs that referenced this pull request Mar 17, 2023
# Description
The description of the main changes of your pull request

# Related Issue(s)

- closes delta-io#715
- closes delta-io#373


# Documentation

<!---
Share links to useful documentation
--->

---------

Co-authored-by: Robert Pack <42610831+roeap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python write_deltalake: when will this be production ready? Missing Contribution guideline file
2 participants