Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for extract_partition_values #1159

Merged
merged 1 commit into from
Feb 22, 2023
Merged

add test for extract_partition_values #1159

merged 1 commit into from
Feb 22, 2023

Conversation

marijncv
Copy link
Contributor

Description

Adds a test for rust/src/writer/json.rs::extract_partition_values

@marijncv
add test for extract_partition_values
fbdaa58 
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Feb 19, 2023
wjones127
wjones127 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good @marijncv

As a related follow-up, would you be interested in working on #1170? That could also use more tests.

@wjones127 wjones127 merged commit 7a50035 into delta-io:main Feb 22, 2023
chitralverma pushed a commit to chitralverma/delta-rs that referenced this pull request Mar 17, 2023
@marijncv @chitralverma
add test for extract_partition_values (delta-io#1159)
e675fea 
# Description
Adds a test for `rust/src/writer/json.rs::extract_partition_values`

Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

@houqp houqp Awaiting requested review from houqp

@xianwill xianwill Awaiting requested review from xianwill

@fvaleye fvaleye Awaiting requested review from fvaleye

@roeap roeap Awaiting requested review from roeap

@rtyler rtyler Awaiting requested review from rtyler

@mosyp mosyp Awaiting requested review from mosyp

Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marijncv @wjones127