refactor!: remove DeltaDataType aliases
#1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmackenzie1
requested review from
xianwill,
houqp,
rtyler,
mosyp,
wjones127,
fvaleye and
roeap
as code owners
github-actions
bot
added
binding/python
Removing the aliases in favor of the actual type to improve readability of the code and reduce confusion around the existence of the types. `DeltaDataTypeLong` replaced with `i64` `DeltaDataTypeVersion` replaced with `i64` `DeltaDataTypeTimestamp` replaced with `i64` `DeltaDataTypeInt` replaced with `i32`
roeap
approved these changes
May 23, 2023
There was a problem hiding this comment.
Thanks @cmackenzie1, I agree that this is an improvement, but I'll leave it open a bit for other opinions :)
wjones127
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the aliases in favor of the actual type to improve readability of the code and reduce confusion around the existence of the types.
DeltaDataTypeLongreplaced withi64DeltaDataTypeVersionreplaced withi64DeltaDataTypeTimestampreplaced withi64DeltaDataTypeIntreplaced withi32Related Issue(s)
N/A
Documentation
N/A