feat: more efficient parquet writer and more statistics #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
May 27, 2023
| @@ -324,40 +318,27 @@ impl PartitionWriter { | |||
| } | |||
|
|
|||
| fn write_batch(&mut self, batch: &RecordBatch) -> DeltaResult<()> { | |||
| // copy current cursor bytes so we can recover from failures | |||
| // TODO is copying this something we should be doing? | |||
| let buffer_bytes = self.buffer.to_vec(); | |||
There was a problem hiding this comment.
This was the offending line causing a lot of data copying.
wjones127
commented
May 27, 2023
| @@ -528,7 +698,7 @@ mod tests { | |||
| ("some_bool", ColumnCountStat::Value(v)) => assert_eq!(100, *v), | |||
| ("some_string", ColumnCountStat::Value(v)) => assert_eq!(100, *v), | |||
| ("some_list", ColumnCountStat::Value(v)) => assert_eq!(100, *v), | |||
| ("some_nested_list", ColumnCountStat::Value(v)) => assert_eq!(0, *v), | |||
| ("some_nested_list", ColumnCountStat::Value(v)) => assert_eq!(100, *v), | |||
There was a problem hiding this comment.
I believe this test was incorrect, given the null values here:
delta-rs/rust/src/writer/stats.rs
Line 885 in 0ee692c
wjones127
requested review from
houqp,
xianwill,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
rtyler
previously approved these changes
May 28, 2023
roeap
previously approved these changes
May 28, 2023
rust/src/writer/stats.rs
Outdated
| @@ -448,6 +615,8 @@ mod tests { | |||
| let mut null_count_keys = vec!["some_list", "some_nested_list"]; | |||
| null_count_keys.extend_from_slice(min_max_keys.as_slice()); | |||
|
|
|||
| dbg!(&stats); | |||
| } | ||
|
|
||
| impl AddAssign for AggregatedStats { | ||
| fn add_assign(&mut self, rhs: Self) { |
roeap
previously approved these changes
May 28, 2023
roeap
approved these changes
May 28, 2023
roeap
pushed a commit
to roeap/delta-rs
that referenced
this pull request
Jun 2, 2023
# Description * Removed the data copies in a tight loop, which were extremely bad for performance when writing files > 100MB. * Rewrote statistics handling to collect null values from metadata, just like min and max. * Added support for more types in statistics. # Related Issue(s) - closes delta-io#1394 - closes delta-io#1209 - closes delta-io#1208 # Documentation <!--- Share links to useful documentation --->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Documentation