refactor: use pa.table.cast in delta_arrow_schema_from_pandas #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
rtyler,
roeap and
houqp
as code owners
ion-elgreco
changed the title
ion-elgreco
changed the title
wjones127
approved these changes
Aug 6, 2023
polynomialherder
pushed a commit
to polynomialherder/delta-rs
that referenced
this pull request
Aug 15, 2023
…io#1573) # Description I noticed that `pa.Table.from_pandas` was called twice even after the schema was constructed. Seems more efficient to just cast the existing that data has been read into memory with the newly created schema. Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
pa.Table.from_pandaswas called twice even after the schema was constructed. Seems more efficient to just cast the existing that data has been read into memory with the newly created schema.