feat: add metadata for operations::write::WriteBuilder #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
rtyler
previously approved these changes
Aug 6, 2023
Thanks for the review. I'm not much aware about the test setup in the repo. Could you please let me know which place I can add the test for this change? |
abhimanyusinghgaur
force-pushed
the
main
branch
from
9b55f4d
to
361d1b3
Compare
|
@rtyler I have added tests. Please have a look and let me know if there's anything else required. Also, if you could please let me know approximately when the next version of delta-rs would be released with these changes? Thanks |
polynomialherder
pushed a commit
to polynomialherder/delta-rs
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply provides a way to add commit metadata during
DeltaOps::write()operation similar toDeltaOps::update().Related Issue(s)
None
Documentation
None