fix: compensate for invalid log files created by Delta Live Tables #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would appear that in some cases Delta Live Tables will create a Delta table which does not adhere to the Delta Table protocol. The metaData action as a **required** `schemaString` property which simply doesn't exist. Since it appears that this only exists at version zero of the transaction log, and the _actual_ schema exists in the following versions of the table (e.g. 1), this change introduces a default deserializer on the MetaData action which provides a simple empty schema. This is an alternative implementation to delta-io#1305 which is a bit more invasive and makes our schema_string struct member `Option<String>` which I do not believe is worth it for this unfortunate compatibility issue Closes delta-io#1305, delta-io#1302, delta-io#1357 Sponsored-by: Databricks Inc
rtyler
force-pushed
the
dlt-compatibility
branch
from
e0c0f54
to
f6cb3ca
Compare
rtyler
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap and
mosyp
as code owners
|
Removing mention of #1357 from PR description, since I think tagging that was accidental. |
wjones127
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that in some cases Delta Live Tables will create a Delta table which does not adhere to the Delta Table protocol.
The metaData action as a required
schemaStringproperty which simply doesn't exist. Since it appears that this only exists at version zero of the transaction log, and the actual schema exists in the following versions of the table (e.g. 1), this change introduces a default deserializer on the MetaData action which provides a simple empty schema.This is an alternative implementation to #1305 which is a bit more invasive and makes our schema_string struct member
Option<String>which I do not believe is worth it for this unfortunate compatibility issueCloses #1305, #1302