feat: compare timestamp partition values as timestamps instead of strings #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description Delta protocol specifies 2 possible formats for timestamp partitions (https://github.com/delta-io/delta/blob/master/PROTOCOL.md#partition-value-serialization) : {year}-{month}-{day} {hour}:{minute}:{second} or {year}-{month}-{day} {hour}:{minute}:{second}.{microsecond} However, string comparison of partition filter value and partition values was performed, which rendered timestamps like 2020-12-31 23:59:59.000000 and 2020-12-31 23:59:59 as different. This change uses timestamp comparison instead of string comparison.
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
sigorbor
changed the title
natinimni
reviewed
Nov 21, 2023
|
@rtyler, @roeap, @wjones127 - guys, could you please review? |
rtyler
approved these changes
Nov 30, 2023
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Dec 1, 2023
…ings (delta-io#1895) Delta protocol specifies 2 possible formats for timestamp partitions: {year}-{month}-{day} {hour}:{minute}:{second} or {year}-{month}-{day} {hour}:{minute}:{second}.{microsecond} However, string comparison of partition filter value and partition values was performed, which rendered timestamps like 2020-12-31 23:59:59.000000 and 2020-12-31 23:59:59 as different. This change uses timestamp comparison instead of string comparison. Co-authored-by: Igor Borodin <igborodi@microsoft.com>
natinimni
added a commit
to natinimni/delta-rs
that referenced
this pull request
Jan 31, 2024
…ings (delta-io#1895) Delta protocol specifies 2 possible formats for timestamp partitions: {year}-{month}-{day} {hour}:{minute}:{second} or {year}-{month}-{day} {hour}:{minute}:{second}.{microsecond} However, string comparison of partition filter value and partition values was performed, which rendered timestamps like 2020-12-31 23:59:59.000000 and 2020-12-31 23:59:59 as different. This change uses timestamp comparison instead of string comparison. Co-authored-by: Igor Borodin <igborodi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delta protocol specifies 2 possible formats for timestamp partitions: {year}-{month}-{day} {hour}:{minute}:{second} or {year}-{month}-{day} {hour}:{minute}:{second}.{microsecond}
However, string comparison of partition filter value and partition values was performed, which rendered timestamps like 2020-12-31 23:59:59.000000 and 2020-12-31 23:59:59 as different.
This change uses timestamp comparison instead of string comparison.
Documentation
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#partition-value-serialization