Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): expose custom metadata to writers #1994

Merged
merged 6 commits into from
Jan 2, 2024
Merged

feat(python): expose custom metadata to writers #1994

merged 6 commits into from
Jan 2, 2024

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Dec 27, 2023 •
edited
Loading

Description

  • exposes the custom_metadata to pyarrow and rust writer
  • addresses a bug in the create operation, we were not passing the app_metadata to the actual commit

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Dec 27, 2023
@ion-elgreco ion-elgreco mentioned this pull request Dec 27, 2023
Closed
@ion-elgreco ion-elgreco changed the title feat(python): expose custom metadata to rust engine writer feat(python): expose custom metadata to writers Dec 27, 2023
@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Dec 27, 2023
@r3stl355
Copy link
Contributor

LGTM

@ion-elgreco ion-elgreco enabled auto-merge (squash) January 1, 2024 09:22
@ion-elgreco ion-elgreco merged commit 093a756 into delta-io:main Jan 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3stl355 r3stl355 r3stl355 left review comments

@rtyler rtyler rtyler approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate crate/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

store userMetadata on write operations
3 participants
@ion-elgreco @r3stl355 @rtyler