feat(python, rust): expose custom_metadata for all operations #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
changed the title
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap and
rtyler
as code owners
rtyler
reviewed
Jan 6, 2024
There was a problem hiding this comment.
Do you have the time to add some tests in here @ion-elgreco ? The code looks sensible to me, but it does make me uneasy with every operation touched
|
@rtyler definitely! In rust or python? |
rtyler
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposing custom_metadata/app_metadata now to all operations to harmonize the API.
Closes